Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 913247c378d5 from chromium #23011

Merged
merged 4 commits into from Apr 10, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Apr 8, 2020

Use SupportsWeakPtr for messaging from rendering thread to main thread

In cross-thread messaging, the associated execution context can be
already gone when a posted task is performed sometime later in the task
runner's queue.

By using WeakPtr, the task runner will not perform a scheduled task
in the queue when the target object is invalid.

Test: Locally confirmed that the repro does not crash.
Bug: 1057627
Change-Id: I51737594c918f6a4924c9a7ffe30db3e8de9a683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082897
Commit-Queue: Hongchan Choi hongchan@chromium.org
Reviewed-by: Raymond Toy rtoy@chromium.org
Cr-Commit-Position: refs/heads/master@{#746613}

Notes: Security: backported fix for CVE-2020-6429: Use after free in audio.

ppontes
ppontes approved these changes Apr 9, 2020
@nornagon nornagon merged commit 3bf5ad2 into 7-2-x Apr 10, 2020
6 of 13 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 10, 2020

Release Notes Persisted

Security: backported fix for CVE-2020-6429: Use after free in audio.

@nornagon nornagon deleted the cherry-pick/7-2-x/chromium/913247c378d5 branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants