Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 2cd0af7ea205 from chromium #23015

Merged
merged 3 commits into from Apr 10, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Apr 8, 2020

Use WeakPtr for cross-thread posting

{IIR,Biquad}FilterNodes check the state of the filter and notify the
main thread when it goes bad. In this process, the associated context
can be collected when a posted task is performed sometime later
in the task runner's queue.

By using WeakPtr, the task runner will not perform a scheduled task
in the queue when the target object is invalid anymore.

Test: Locally confirmed that the repro case does not crash after 30 min.
Bug: 1055788
Change-Id: Icdb3a7378d0345936b5b50e12ec2b187e58a611c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074807
Commit-Queue: Hongchan Choi hongchan@chromium.org
Reviewed-by: Raymond Toy rtoy@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Cr-Commit-Position: refs/heads/master@{#744936}

Notes: Security: backported fix for CVE-2020-6427: Use after free in audio.

ppontes
ppontes approved these changes Apr 9, 2020
@nornagon
Copy link
Member Author

@nornagon nornagon commented Apr 10, 2020

Skipping most CI as minimal changes since last green.

@nornagon nornagon merged commit 6e94fb3 into 7-2-x Apr 10, 2020
12 of 15 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 10, 2020

Release Notes Persisted

Security: backported fix for CVE-2020-6427: Use after free in audio.

@nornagon nornagon deleted the cherry-pick/7-2-x/chromium/2cd0af7ea205 branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants