Skip to content

fix: heap-use-after-free in tray.popUpContextMenu #23182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nornagon merged 1 commit into from
Apr 21, 2020
Merged

fix: heap-use-after-free in tray.popUpContextMenu #23182

nornagon merged 1 commit into from
Apr 21, 2020

Conversation

@nornagon
Copy link
Contributor

@nornagon nornagon commented Apr 20, 2020

Backport of #22842. See that change for details

Notes: Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 20, 2020
@trop trop bot mentioned this pull request Apr 20, 2020
Merged
5 tasks
@trop trop bot added 7-2-x backport This is a backport PR labels Apr 20, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 20, 2020
@nornagon nornagon merged commit fb6f604 into 7-2-x Apr 21, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 21, 2020

Release Notes Persisted

Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu.

@zcbenz zcbenz deleted the backport/7-2-x/fix-tray-context-menu-uaf branch February 15, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

7-2-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nornagon @codebytere