Skip to content

fix: block custom window.open when nativeWindowOpen is true #23188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarshallOfSound merged 1 commit into from
Apr 22, 2020
Merged

fix: block custom window.open when nativeWindowOpen is true #23188

MarshallOfSound merged 1 commit into from
Apr 22, 2020

Conversation

@nornagon
Copy link
Contributor

@nornagon nornagon commented Apr 21, 2020

Description of Change

This prevents windows that have nativeWindowOpen: true (or sandbox: true which implies it) from being able to use the ELECTRON_GUEST_WINDOW_MANAGER_WINDOW_OPEN ipc event, which handles non-native window.open calls.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 21, 2020
MarshallOfSound
MarshallOfSound reviewed Apr 21, 2020
View reviewed changes
@nornagon nornagon force-pushed the block-custom-open branch from da2e631 to 0c43361 Compare April 21, 2020 20:01
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 22, 2020
@MarshallOfSound MarshallOfSound merged commit c798a6e into master Apr 22, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 22, 2020 •
edited by nornagon
Loading

Release Notes Persisted

Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path.

@MarshallOfSound MarshallOfSound deleted the block-custom-open branch April 22, 2020 17:48
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I have automatically backported this PR to "9-x-y", please check out #23222

nornagon added a commit that referenced this pull request Apr 22, 2020
@nornagon
fix: block custom window.open when nativeWindowOpen is true (#23188)
5a7bce2
@nornagon nornagon mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@nornagon has manually backported this PR to "7-2-x", please check out #23224

nornagon added a commit that referenced this pull request Apr 22, 2020
@nornagon
fix: block custom window.open when nativeWindowOpen is true (#23188)
e60e900
@nornagon nornagon mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@nornagon has manually backported this PR to "8-x-y", please check out #23225

MarshallOfSound pushed a commit that referenced this pull request Apr 23, 2020
@nornagon
fix: block custom window.open when nativeWindowOpen is true (#23188) (#…
e3c1292 
…23225)
zcbenz pushed a commit that referenced this pull request Apr 27, 2020
@nornagon
fix: block custom window.open when nativeWindowOpen is true (#23188) (#…
7dfcb5e 
…23224)

* fix: block custom window.open when nativeWindowOpen is true (#23188)

* fix lint

* Update chromium-spec.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nornagon @deepak1556 @MarshallOfSound