Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block custom window.open when nativeWindowOpen is true #23188

Merged
merged 1 commit into from Apr 22, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Apr 21, 2020

Description of Change

This prevents windows that have nativeWindowOpen: true (or sandbox: true which implies it) from being able to use the ELECTRON_GUEST_WINDOW_MANAGER_WINDOW_OPEN ipc event, which handles non-native window.open calls.

Checklist

Release Notes

Notes: none

@nornagon nornagon force-pushed the block-custom-open branch from da2e631 to 0c43361 Apr 21, 2020
@MarshallOfSound MarshallOfSound merged commit c798a6e into master Apr 22, 2020
18 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 22, 2020

Release Notes Persisted

Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path.

@MarshallOfSound MarshallOfSound deleted the block-custom-open branch Apr 22, 2020
@trop
Copy link
Contributor

@trop trop bot commented Apr 22, 2020

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

@trop trop bot commented Apr 22, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

@trop trop bot commented Apr 22, 2020

I have automatically backported this PR to "9-x-y", please check out #23222

@trop
Copy link
Contributor

@trop trop bot commented Apr 22, 2020

@nornagon has manually backported this PR to "7-2-x", please check out #23224

@trop
Copy link
Contributor

@trop trop bot commented Apr 22, 2020

@nornagon has manually backported this PR to "8-x-y", please check out #23225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants