Skip to content

fix: do not mutate ipc instances across contexts #23239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarshallOfSound merged 1 commit into from
Apr 23, 2020
Merged

fix: do not mutate ipc instances across contexts #23239

MarshallOfSound merged 1 commit into from
Apr 23, 2020

Conversation

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Apr 22, 2020

Backport of #23236

See that PR for details.

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 22, 2020
@trop trop bot mentioned this pull request Apr 22, 2020
Merged
@trop trop bot added 7-2-x backport This is a backport PR labels Apr 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 22, 2020
@MarshallOfSound MarshallOfSound merged commit 0b3bf1e into 7-2-x Apr 23, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 23, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the no-ipc-mutate-7 branch April 23, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nornagon nornagon nornagon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

7-2-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarshallOfSound @nornagon