Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use build/include_directory for NOLINT #23266

Merged
merged 1 commit into from Apr 24, 2020
Merged

Conversation

@sorah
Copy link
Contributor

@sorah sorah commented Apr 24, 2020

Description of Change

build/include linter was splitted to build/include_directory at depot_tools upstream.
Fixing PR lint check failure. (seen here: https://github.com/electron/electron/runs/614050973 #23247)

https://crrev.com/c/2159690
https://crbug.com/1073191

Checklist

Release Notes

Notes: none

build/include linter was splitted to build/include_directory at
depot_tools upstream.

https://crrev.com/c/2159690
https://crbug.com/1073191
Copy link
Member

@deepak1556 deepak1556 left a comment

Thanks!

@deepak1556 deepak1556 merged commit 6ab317c into electron:master Apr 24, 2020
7 of 9 checks passed
@welcome
Copy link

@welcome welcome bot commented Apr 24, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 24, 2020

No Release Notes

@sorah sorah deleted the directory branch Apr 25, 2020
@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Apr 27, 2020

/trop run backport-to 9-x-y

@trop
Copy link
Contributor

@trop trop bot commented Apr 27, 2020

The backport process for this PR has been manually initiated -
sending your commits to "9-x-y"!

@trop
Copy link
Contributor

@trop trop bot commented Apr 27, 2020

I have automatically backported this PR to "9-x-y", please check out #23300

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Apr 27, 2020

/trop run backport-to 8-x-y

@trop
Copy link
Contributor

@trop trop bot commented Apr 27, 2020

The backport process for this PR has been manually initiated -
sending your commits to "8-x-y"!

@trop
Copy link
Contributor

@trop trop bot commented Apr 27, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

MarshallOfSound added a commit that referenced this issue Apr 27, 2020
build/include linter was splitted to build/include_directory at
depot_tools upstream.

https://crrev.com/c/2159690
https://crbug.com/1073191
@trop
Copy link
Contributor

@trop trop bot commented Apr 27, 2020

@MarshallOfSound has manually backported this PR to "8-x-y", please check out #23303

MarshallOfSound added a commit that referenced this issue Apr 27, 2020
build/include linter was splitted to build/include_directory at
depot_tools upstream.

https://crrev.com/c/2159690
https://crbug.com/1073191

Co-authored-by: Sorah Fukumori <sora134@gmail.com>
trop bot pushed a commit that referenced this issue Apr 27, 2020
build/include linter was splitted to build/include_directory at
depot_tools upstream.

https://crrev.com/c/2159690
https://crbug.com/1073191
MarshallOfSound pushed a commit that referenced this issue Apr 27, 2020
build/include linter was splitted to build/include_directory at
depot_tools upstream.

https://crrev.com/c/2159690
https://crbug.com/1073191

Co-authored-by: Sorah Fukumori <sora134@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants