Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run Node.js at-exit callbacks in renderer proc #23564

Merged
merged 1 commit into from May 14, 2020
Merged

fix: run Node.js at-exit callbacks in renderer proc #23564

merged 1 commit into from May 14, 2020

Conversation

codebytere
Copy link
Member

Backport of #23419

See that PR for details.

Notes: Ensured that exit callbacks are run for Node.js in the renderer process.

@codebytere codebytere requested a review from a team May 13, 2020 16:07
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 13, 2020
@trop trop bot mentioned this pull request May 13, 2020
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels May 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 13, 2020
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 42ab97f into 8-x-y May 14, 2020
@release-clerk
Copy link

release-clerk bot commented May 14, 2020

Release Notes Persisted

Ensured that exit callbacks are run for Node.js in the renderer process.

@jkleinsc jkleinsc deleted the exit-callbacks-8 branch May 14, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc