Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick d795ac1209c8 and 919dd0c1244a from chromium #23788

Merged
merged 2 commits into from May 28, 2020

Conversation

ppontes
Copy link
Member

@ppontes ppontes commented May 27, 2020

Backports the 2-part fix to https://crbug.com/1068084

===

Avoid nullptr dereference in RTCPeerConnectionHandler

Bug: 1071327
Change-Id: Icf4189905dc5c95854b5af4b3e5e25e0607dd39e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153325
Reviewed-by: Harald Alvestrand hta@chromium.org
Commit-Queue: Dan McArdle dmcardle@chromium.org
Cr-Commit-Position: refs/heads/master@{#759775}

===

Onstate handler is allowed to close a PeerConnection.

Bug: chromium:1068084
Change-Id: Icd3f70b6784ac22ef4e3bc1c99233f51145a917f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146542
Commit-Queue: Harald Alvestrand hta@chromium.org
Reviewed-by: Guido Urdaneta guidou@chromium.org
Cr-Commit-Position: refs/heads/master@{#759242}

===

Release Notes

Notes: backported the fix for CVE-2020-6467: UAF in WebRTC.

Backports the 2-part fix to https://crbug.com/1068084

===

Avoid nullptr dereference in RTCPeerConnectionHandler

Bug: 1071327
Change-Id: Icf4189905dc5c95854b5af4b3e5e25e0607dd39e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153325
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759775}

===

Onstate handler is allowed to close a PeerConnection.

Bug: chromium:1068084
Change-Id: Icd3f70b6784ac22ef4e3bc1c99233f51145a917f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146542
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759242}

===
@ppontes ppontes added 8-x-y backport-check-skip Skip trop's backport validity checking labels May 27, 2020
@ppontes ppontes requested a review from a team as a code owner May 27, 2020 10:41
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 27, 2020
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 28, 2020
@jkleinsc jkleinsc merged commit 936a165 into 8-x-y May 28, 2020
@release-clerk
Copy link

release-clerk bot commented May 28, 2020

Release Notes Persisted

backported the fix for CVE-2020-6467: UAF in WebRTC.

@jkleinsc jkleinsc deleted the cherry-pick/8-x-y/chromium/919dd0c1244a branch May 28, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants