fix: default to NTLM v2 in the network service for POSIX platforms #23935

deepak1556 · 2020-06-03T06:11:54Z

Backports #23846

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Notes: enable NTLM v2 for POSIX platforms and added --disable-ntlm-v2 switch to disable it.

deepak1556 · 2020-06-03T18:47:27Z

Failing test is unrelated, merging.

release-clerk · 2020-06-03T18:47:38Z

Release Notes Persisted

enable NTLM v2 for POSIX platforms and added --disable-ntlm-v2 switch to disable it.

deepak1556 added 2 commits June 2, 2020 22:55

fix: default to NTLM v2 in the network service for POSIX platforms

5025929

chore: update patch

9e8a85f

deepak1556 requested a review from a team as a code owner June 3, 2020 06:11

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020

trop bot mentioned this pull request Jun 3, 2020

fix: default to NTLM v2 in the network service for POSIX platforms #23846

Merged

6 tasks

trop bot added 7-3-x backport This is a backport PR labels Jun 3, 2020

deepak1556 requested a review from a team June 3, 2020 06:12

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020

codebytere approved these changes Jun 3, 2020

View reviewed changes

deepak1556 merged commit 669fd2b into 7-3-x Jun 3, 2020

deepak1556 deleted the robo/ntlm_v2_7_x branch June 3, 2020 18:47

Provide feedback