feat: implement systemPreferences.getMediaAccessStatus() on Windows #24275

miniak · 2020-06-24T00:38:07Z

Description of Change

Implement systemPreferences.getMediaAccessStatus() on Windows

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
This is NOT A BREAKING CHANGE. Breaking changes may not be merged to master until 11-x-y is branched.

Release Notes

Notes: Implemented systemPreferences.getMediaAccessStatus() on Windows.

deepak1556

Looks solid 👍

deepak1556 · 2020-06-24T00:54:42Z

shell/browser/api/electron_api_system_preferences_win.cc

+    return ConvertDeviceAccessStatus(
+        DeviceAccessStatus::DeviceAccessStatus_Allowed);
+  } else {
+    args->ThrowError("Invalid media type");


Not originating from this PR but when we have a unknown state in the docs, why do we want to throw an error ? seem to do it for macOS as well.

@deepak1556 The return type can have unknown, the media_type argument can't be unknown

For an unknown media type why can't the return type by unknown, the current system calls both on windows and macOS never return an unknown state, the value is being unused. I wouldn't mind if this state wasn't documented but it is :)

Would be good to bring this up with api-WG

I can address it in a separate PR.

shell/browser/api/electron_api_system_preferences_win.cc

MarshallOfSound · 2020-06-24T15:53:02Z

docs/api/system-preferences.md

@@ -426,6 +426,9 @@ This user consent was not required on macOS 10.13 High Sierra or lower so this m
 macOS 10.14 Mojave or higher requires consent for `microphone` and `camera` access.
 macOS 10.15 Catalina or higher requires consent for `screen` access.

+Windows 10 has a global setting controlling `microphone` and `camera` access for all win32 applications.


If this is specific for win32 applications should we safety check if for APPX / Window Store builds?

The system API returns the global value, it should work fine. Electron Window Store app is still Win32.

codebytere

Looks good from an impl perspective, & i agree we might want to discuss the unknown type but don't think it should necessarily block this PR :)

release-clerk · 2020-06-25T16:47:55Z

Release Notes Persisted

Implemented systemPreferences.getMediaAccessStatus() on Windows.

miniak · 2020-06-26T14:18:54Z

/trop run backport-to 8-x-y

trop · 2020-06-26T14:18:55Z

The backport process for this PR has been manually initiated -
sending your commits to "8-x-y"!

trop · 2020-06-26T14:19:08Z

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

miniak · 2020-06-26T14:23:38Z

/trop run backport-to 9-x-y

trop · 2020-06-26T14:23:40Z

The backport process for this PR has been manually initiated -
sending your commits to "9-x-y"!

trop · 2020-06-26T14:23:52Z

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

miniak · 2020-06-26T14:24:10Z

/trop run backport-to 10-x-y

trop · 2020-06-26T14:24:12Z

The backport process for this PR has been manually initiated -
sending your commits to "10-x-y"!

trop · 2020-06-26T14:24:35Z

I have automatically backported this PR to "10-x-y", please check out #24311

…24275)

trop · 2020-06-26T14:52:04Z

@miniak has manually backported this PR to "9-x-y", please check out #24312

…24275)

trop · 2020-06-26T14:57:04Z

@miniak has manually backported this PR to "8-x-y", please check out #24313

…24275)

…24275) (#24312)

…24275)

…lectron#24275)

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 24, 2020

miniak requested review from zcbenz, codebytere and deepak1556 and removed request for zcbenz June 24, 2020 00:38

deepak1556 approved these changes Jun 24, 2020

View reviewed changes

codebytere reviewed Jun 24, 2020

View reviewed changes

shell/browser/api/electron_api_system_preferences_win.cc Show resolved Hide resolved

feat: implement systemPreferences.getMediaAccessStatus() on Windows

8c471b4

miniak force-pushed the miniak/device-permissions-win branch from d058966 to 8c471b4 Compare June 24, 2020 12:35

miniak requested a review from codebytere June 24, 2020 12:58

MarshallOfSound reviewed Jun 24, 2020

View reviewed changes

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 25, 2020

codebytere approved these changes Jun 25, 2020

View reviewed changes

deepak1556 merged commit 9b4572d into master Jun 25, 2020

deepak1556 deleted the miniak/device-permissions-win branch June 25, 2020 16:47

trop bot added the needs-manual-bp/8-x-y label Jun 26, 2020

trop bot added the needs-manual-bp/9-x-y label Jun 26, 2020

trop bot mentioned this pull request Jun 26, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows #24311

Merged

trop bot added the in-flight/10-x-y label Jun 26, 2020

miniak added a commit that referenced this pull request Jun 26, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (#…

b37f3ad

…24275)

miniak mentioned this pull request Jun 26, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows #24312

Merged

trop bot added in-flight/9-x-y and removed needs-manual-bp/9-x-y labels Jun 26, 2020

miniak added a commit that referenced this pull request Jun 26, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (#…

9536a9f

…24275)

miniak mentioned this pull request Jun 26, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows #24313

Merged

trop bot added in-flight/8-x-y and removed needs-manual-bp/8-x-y labels Jun 26, 2020

miniak self-assigned this Jun 26, 2020

trop bot added merged/10-x-y and removed in-flight/10-x-y labels Jul 1, 2020

miniak added a commit that referenced this pull request Jul 3, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (#…

93516c6

…24275)

miniak added a commit that referenced this pull request Jul 3, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (#…

2fa2678

…24275)

trop bot added merged/9-x-y and removed in-flight/9-x-y labels Jul 6, 2020

codebytere pushed a commit that referenced this pull request Jul 6, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (#…

4f10bde

…24275) (#24312)

miniak added a commit that referenced this pull request Jul 6, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (#…

7ac93d3

…24275)

miniak added a commit that referenced this pull request Jul 6, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (#…

31b90f9

…24275)

trop bot added merged/8-x-y and removed in-flight/8-x-y labels Jul 7, 2020

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows (e…

6552ca2

…lectron#24275)

sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021

feat: implement systemPreferences.getMediaAccessStatus() on Windows (e…

7d66fc0

…lectron#24275)

feat: implement systemPreferences.getMediaAccessStatus() on Windows #24275

feat: implement systemPreferences.getMediaAccessStatus() on Windows #24275

miniak commented Jun 24, 2020

deepak1556 left a comment

deepak1556 Jun 24, 2020

MarshallOfSound Jun 24, 2020

deepak1556 Jun 24, 2020

deepak1556 Jun 24, 2020

miniak Jun 25, 2020

deepak1556 Jun 25, 2020

MarshallOfSound Jun 24, 2020

miniak Jun 24, 2020 •

edited

codebytere left a comment

release-clerk bot commented Jun 25, 2020

miniak commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

miniak commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

miniak commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

feat: implement systemPreferences.getMediaAccessStatus() on Windows #24275

feat: implement systemPreferences.getMediaAccessStatus() on Windows #24275

Conversation

miniak commented Jun 24, 2020

Description of Change

Checklist

Release Notes

deepak1556 left a comment

Choose a reason for hiding this comment

deepak1556 Jun 24, 2020

Choose a reason for hiding this comment

MarshallOfSound Jun 24, 2020

Choose a reason for hiding this comment

deepak1556 Jun 24, 2020

Choose a reason for hiding this comment

deepak1556 Jun 24, 2020

Choose a reason for hiding this comment

miniak Jun 25, 2020

Choose a reason for hiding this comment

deepak1556 Jun 25, 2020

Choose a reason for hiding this comment

MarshallOfSound Jun 24, 2020

Choose a reason for hiding this comment

miniak Jun 24, 2020 • edited

Choose a reason for hiding this comment

codebytere left a comment

Choose a reason for hiding this comment

release-clerk bot commented Jun 25, 2020

miniak commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

miniak commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

miniak commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

trop bot commented Jun 26, 2020

miniak Jun 24, 2020 •

edited