Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Node.js cpu and heap profiling #24542

Merged
merged 2 commits into from Jul 20, 2020
Merged

fix: Node.js cpu and heap profiling #24542

merged 2 commits into from Jul 20, 2020

Conversation

codebytere
Copy link
Member

Backport of #24528.

See that PR for more details.

Notes: Fixed an issue where cpu and heap profiling in Node.js did not work properly with --cpu-prof, --heap-prof, and related CLI flags.

@codebytere
fix: Node.js cpu and heap profiling
baa64cd 
* fix: Node.js cpu and heap profiling

* chore: enable more now-working Node.js specs
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2020
@trop trop bot mentioned this pull request Jul 14, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jul 14, 2020
@codebytere codebytere requested a review from a team July 14, 2020 16:08
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 14, 2020
@codebytere
Copy link
Member Author

We can't re-enabled tests here owing to: #23213 not being in this branch as it hasn't been exposed yet. The tests use assert.ok which dies as we don't use Node.js' prepareStackTrace callback in this PR. This should be otherwise good to go though.

@codebytere codebytere requested a review from jkleinsc July 20, 2020 16:42
jkleinsc
jkleinsc approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarshallOfSound MarshallOfSound merged commit f3df14c into 8-x-y Jul 20, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 20, 2020

Release Notes Persisted

Fixed an issue where cpu and heap profiling in Node.js did not work properly with --cpu-prof, --heap-prof, and related CLI flags.

@MarshallOfSound MarshallOfSound deleted the node-heap-prof-8 branch July 20, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @ckerr @jkleinsc @MarshallOfSound