Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use non-symbols in isURLInstance check #24861

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Aug 5, 2020

Backport of #24831

See that PR for details.

Notes: Fixed an issue where some Node.js methods would not work with URL instances constructed in the renderer process.

@trop trop bot requested a review from electron/wg-upgrades as a code owner Aug 5, 2020
@trop trop bot requested a review from codebytere Aug 5, 2020
@trop trop bot mentioned this pull request Aug 5, 2020
6 of 6 tasks complete
@codebytere codebytere force-pushed the trop/8-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166633 branch from 3a1d8ac to bd113d6 Aug 6, 2020
@codebytere codebytere force-pushed the trop/8-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166633 branch from bd113d6 to e81593e Aug 6, 2020
Electron Bot added 3 commits Aug 6, 2020
Copy link
Member

@zcbenz zcbenz left a comment

Patch needs to be updated.

@codebytere codebytere dismissed zcbenz’s stale review Aug 17, 2020

Dismissing as patches have been successfully updated

@codebytere
Copy link
Member

@codebytere codebytere commented Aug 17, 2020

chromium features window.history window.history.pushState should push state after calling history.pushState() from the same url

is unrelated.

@codebytere codebytere merged commit 0e7e4fe into 8-x-y Aug 17, 2020
15 of 16 checks passed
15 of 16 checks passed
@azure-pipelines
electron-woa-testing Build #20200817.5 had test failures
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@trop
Valid Backport Valid Backport
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm-testing Build #20200817.5 succeeded
Details
@azure-pipelines
electron-arm64-testing Build #20200817.5 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 17, 2020

Release Notes Persisted

Fixed an issue where some Node.js methods would not work with URL instances constructed in the renderer process.

@codebytere codebytere deleted the trop/8-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166633 branch Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants