Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use non-symbols in isURLInstance check #24861

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 5, 2020

Backport of #24831

See that PR for details.

Notes: Fixed an issue where some Node.js methods would not work with URL instances constructed in the renderer process.

@trop trop bot requested a review from a team as a code owner Aug 5, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@trop trop bot requested a review from codebytere Aug 5, 2020
@trop trop bot mentioned this pull request Aug 5, 2020
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Aug 5, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@codebytere codebytere force-pushed the trop/8-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166633 branch from 3a1d8ac to bd113d6 Compare Aug 6, 2020
@codebytere codebytere force-pushed the trop/8-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166633 branch from bd113d6 to e81593e Compare Aug 6, 2020
zcbenz
zcbenz previously requested changes Aug 17, 2020
Copy link
Member

@zcbenz zcbenz left a comment

Patch needs to be updated.

@codebytere codebytere dismissed zcbenz’s stale review Aug 17, 2020

Dismissing as patches have been successfully updated

@codebytere
Copy link
Member

codebytere commented Aug 17, 2020

chromium features window.history window.history.pushState should push state after calling history.pushState() from the same url

is unrelated.

@codebytere codebytere merged commit 0e7e4fe into 8-x-y Aug 17, 2020
15 of 16 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 17, 2020

Release Notes Persisted

Fixed an issue where some Node.js methods would not work with URL instances constructed in the renderer process.

@codebytere codebytere deleted the trop/8-x-y-bp-fix-use-non-symbols-in-isurlinstance-check-1596665166633 branch Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants