Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not render inactive titlebar as active on Windows #24875

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Aug 6, 2020

Backport of #24847

See that PR for details.

Notes: Fix inactive windows having active titlebar on Windows

@trop trop bot requested a review from zcbenz Aug 6, 2020
@trop trop bot mentioned this pull request Aug 6, 2020
5 of 5 tasks complete
@codebytere
Copy link
Member

@codebytere codebytere commented Aug 7, 2020

Failures were build job errors - the actual windows CI builds both passed.

@codebytere codebytere merged commit 19cfa2a into 8-x-y Aug 7, 2020
14 of 16 checks passed
14 of 16 checks passed
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build failed
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build failed
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@trop
Valid Backport Valid Backport
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm-testing Build #20200806.12 succeeded
Details
@azure-pipelines
electron-arm64-testing Build #20200806.13 succeeded
Details
@azure-pipelines
electron-woa-testing Build #20200806.19 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 7, 2020

Release Notes Persisted

Fix inactive windows having active titlebar on Windows

@codebytere codebytere deleted the trop/8-x-y-bp-fix-do-not-render-inactive-titlebar-as-active-on-windows-1596729949045 branch Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants