Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not render inactive titlebar as active on Windows #24875

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 6, 2020

Backport of #24847

See that PR for details.

Notes: Fix inactive windows having active titlebar on Windows

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 6, 2020
@trop trop bot requested a review from zcbenz Aug 6, 2020
@trop trop bot added 8-x-y backport This is a backport PR labels Aug 6, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 6, 2020
@codebytere
Copy link
Member

codebytere commented Aug 7, 2020

Failures were build job errors - the actual windows CI builds both passed.

@codebytere codebytere merged commit 19cfa2a into 8-x-y Aug 7, 2020
14 of 16 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 7, 2020

Release Notes Persisted

Fix inactive windows having active titlebar on Windows

@codebytere codebytere deleted the trop/8-x-y-bp-fix-do-not-render-inactive-titlebar-as-active-on-windows-1596729949045 branch Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants