Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save dialog extensions should be deterministic #25164

Merged
merged 1 commit into from Aug 28, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Closes #25152.

The extensions were being added to an NSMutableSet previously, which caused nondeterministic ordering for the first one to appear in the UI when the dialog appeared. This fixes that by leveraging NSOrderedMutableSet to maintain ordering.

cc @jkleinsc @zcbenz @MarshallOfSound

Checklist

Release Notes

Notes: Fixed an issue where filters set in dialogs on macOS would have nondeterministic ordering.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 27, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2020
@codebytere codebytere merged commit c5320b3 into master Aug 28, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 28, 2020

Release Notes Persisted

Fixed an issue where filters set in dialogs on macOS would have nondeterministic ordering.

@trop
Copy link
Contributor

trop bot commented Aug 28, 2020

I have automatically backported this PR to "10-x-y", please check out #25192

@trop
Copy link
Contributor

trop bot commented Aug 28, 2020

I have automatically backported this PR to "11-x-y", please check out #25193

@trop
Copy link
Contributor

trop bot commented Aug 28, 2020

I have automatically backported this PR to "9-x-y", please check out #25194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save dialog: cannot provide a extension to pick when specifying multiple
3 participants