Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: force source code and markdown files to use LF line ending #25176

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 28, 2020

Backport of #25134

With also a change to normalize the line endings of existing files, so future backports would not fail because of line endings change.

See that PR for details.

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2020
@trop trop bot requested a review from zcbenz August 28, 2020 01:32
@trop trop bot added 11-x-y backport This is a backport PR labels Aug 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2020
@zcbenz
Copy link
Member

zcbenz commented Aug 28, 2020

This should not be merged until #25161 gets merged.

@codebytere
Copy link
Member

@zcbenz is this good to merge? do we need to backport anything from the above referenced PR?

@zcbenz
Copy link
Member

zcbenz commented Aug 31, 2020

@codebytere Yeah this is good to go. This backport does 2 things:

  1. Change settings in .gitattributes
  2. Change files' line endings with git add --renormalize .

Which matches #25134 and #25161.

@zcbenz zcbenz merged commit c8944df into 11-x-y Sep 1, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 1, 2020

No Release Notes

@zcbenz zcbenz deleted the trop/11-x-y-bp-chore-force-source-code-and-markdown-files-to-use-lf-line-ending-1598578303461 branch September 1, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants