Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reset process_id in URLLoaderFactoryParams #25181

Merged
merged 1 commit into from Aug 31, 2020
Merged

Conversation

@zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 28, 2020

Backport of #25139

See that PR for details.

Notes: Fix network permission error when there are multiple WebContents sharing same session are created with web security disabled.

@zcbenz zcbenz merged commit caaaa34 into 8-x-y Aug 31, 2020
15 of 16 checks passed
15 of 16 checks passed
@azure-pipelines
electron-woa-testing Build #20200828.15 had test failures
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@trop
Valid Backport Valid Backport
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm-testing Build #20200828.17 succeeded
Details
@azure-pipelines
electron-arm64-testing Build #20200828.17 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 31, 2020

Release Notes Persisted

Fix network permission error when there are multiple WebContents sharing same session are created with web security disabled.

@zcbenz zcbenz deleted the process_id_crash_8 branch Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants