Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reset process_id in URLLoaderFactoryParams #25181

Merged
merged 1 commit into from Aug 31, 2020

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Aug 28, 2020

Backport of #25139

See that PR for details.

Notes: Fix network permission error when there are multiple WebContents sharing same session are created with web security disabled.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2020
@trop trop bot added 8-x-y backport This is a backport PR labels Aug 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 28, 2020
@zcbenz zcbenz merged commit caaaa34 into 8-x-y Aug 31, 2020
15 of 16 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 31, 2020

Release Notes Persisted

Fix network permission error when there are multiple WebContents sharing same session are created with web security disabled.

@zcbenz zcbenz deleted the process_id_crash_8 branch Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants