Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client area inset calculation when maximized for framless windows #25219

Merged
merged 1 commit into from Aug 31, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Aug 31, 2020

Description of Change

Backports #25052

Checklist

Release Notes

Notes:

  • Fixes the following issues for frameless when maximized on Windows:
  • fix unreachable task bar when auto hidden with position top
  • fix 1px extending to secondary monitor
  • fix 1px overflowing into taskbar at certain resolutions
  • fix white line on top of window under 4k resolutions

#25052)

* adopt per monitor scale factor

* fix: client area inset calculation when maximized

* address review feedback

* pass correct glass insets to GetDwmFrameInsetsInPixels

* remove unused code

* Windows 8 and 10 use the same DWM frame calculation

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2020
@trop trop bot added 8-x-y backport This is a backport PR labels Aug 31, 2020
@deepak1556 deepak1556 requested a review from a team Aug 31, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2020
@codebytere codebytere merged commit 9466065 into 8-x-y Aug 31, 2020
14 of 15 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 31, 2020

Release Notes Persisted

  • Fixes the following issues for frameless when maximized on Windows:
  • fix unreachable task bar when auto hidden with position top
  • fix 1px extending to secondary monitor
  • fix 1px overflowing into taskbar at certain resolutions
  • fix white line on top of window under 4k resolutions

@codebytere codebytere deleted the robo/bp_25052_8_x branch Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants