Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick bee371eeaf66 from chromium #25227

Merged
merged 2 commits into from Sep 1, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Aug 31, 2020

Use SupportWeakPtr in OfflineAudioDestinationHandler

OfflineAudioDestinationHandler's render thread notifies the
main thread when the rendering state changes. In this process,
the associated audio context can be deleted when a posted task
is performed sometime later in the task runner's queue.

By using WeakPtr, the task runner will not perform a scheduled task
in the queue when the target object is no longer valid.

(cherry picked from commit 4f309b864587890acaefa9da5d580abb21ff9ca0)

Bug: 1095584
Test: Locally confirmed that the repro case does not crash after 30 min.
Change-Id: Ic1814b97f8d9a8d1027ef04f475112874cfa8137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285473
Reviewed-by: Robert Sesek rsesek@chromium.org
Reviewed-by: Raymond Toy rtoy@chromium.org
Commit-Queue: Hongchan Choi hongchan@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#786381}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335487
Reviewed-by: Hongchan Choi hongchan@chromium.org
Cr-Commit-Position: refs/branch-heads/4147@{#1019}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}

Notes: Security: backported fix for 1095584.

@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Aug 31, 2020
@nornagon nornagon merged commit ab6c822 into 8-x-y Sep 1, 2020
16 checks passed
16 checks passed
@trop
Valid Backport Backport Check Skipped
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm-testing Build #20200831.39 succeeded
Details
@azure-pipelines
electron-arm64-testing Build #20200831.40 succeeded
Details
@azure-pipelines
electron-woa-testing Build #20200901.7 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 1, 2020

Release Notes Persisted

Security: backported fix for 1095584.

@nornagon nornagon deleted the cherry-pick/8-x-y/chromium/bee371eeaf66 branch Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants