Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 138b748dd0a4 from chromium #25232

Merged
merged 3 commits into from Sep 2, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Aug 31, 2020

Update FocusChanged notifiers to operate on a copy

These focus changed calls ultimately trigger javascript events. These
events could potentially run code that would modify the list of items
that the FocusChanged notifiers are notifying, and thus invalidate their
in-use iterators.

Fix this by having these methods iterate over a copy instead of the
member list.

(cherry picked from commit d8f526f4e25c24ed29e60b46b3416bfabd5e8f11)

Fixed: 1107815
Change-Id: I03fa08eeadc60736f3a3fae079253dbd3ee26476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314158
Reviewed-by: Daniel Cheng dcheng@chromium.org
Reviewed-by: Klaus Weidner klausw@chromium.org
Commit-Queue: Daniel Cheng dcheng@chromium.org
Auto-Submit: Alexander Cooper alcooper@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#791261}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335893
Reviewed-by: Alexander Cooper alcooper@chromium.org
Commit-Queue: Alexander Cooper alcooper@chromium.org
Cr-Commit-Position: refs/branch-heads/4147@{#1015}
Cr-Branched-From: 16307825352720ae04d898f37efa5449ad68b606-refs/heads/master@{#768962}

Notes: Security: backported fix for 1107815.

@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Aug 31, 2020
@zcbenz
zcbenz approved these changes Sep 2, 2020
@zcbenz zcbenz merged commit a2d4b65 into 8-x-y Sep 2, 2020
13 of 15 checks passed
13 of 15 checks passed
@appveyor
appveyor: win-woa-testing AppVeyor build failed
Details
@appveyor
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
@trop
Valid Backport Backport Check Skipped
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm-testing Build #20200901.43 succeeded
Details
@azure-pipelines
electron-arm64-testing Build #20200901.34 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 2, 2020

Release Notes Persisted

Security: backported fix for 1107815.

@zcbenz zcbenz deleted the cherry-pick/8-x-y/chromium/138b748dd0a4 branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants