Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 44bb4d7abee6 from angle #25235

Merged
merged 1 commit into from Sep 1, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Aug 31, 2020

D3D11: Fix bug with static vertex attributes.

In some specific cases after binding a zero size buffer we could end
up trying to use a buffer storage that was no longer valid. Fix this
by ensuring we don't flush dirty bits when we have an early exit due
to a zero size buffer.

Also adds a regression test.

Bug: chromium:1107433
Change-Id: I9db560e8dd3699abed2bb7fe6d91060148ba1817
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314216
Commit-Queue: Jamie Madill jmadill@chromium.org
Reviewed-by: Geoff Lang geofflang@chromium.org

Notes: Security: backported fix for 1107433.

@nornagon nornagon requested a review from a team as a code owner Aug 31, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 31, 2020
@nornagon nornagon added 8-x-y backport-check-skip Skip trop's backport validity checking labels Aug 31, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2020
@nornagon
Copy link
Member Author

nornagon commented Sep 1, 2020

CI failures are unrelated.

@nornagon nornagon merged commit 41b7ab3 into 8-x-y Sep 1, 2020
14 of 16 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 1, 2020

Release Notes Persisted

Security: backported fix for 1107433.

@nornagon nornagon deleted the cherry-pick/8-x-y/angle/44bb4d7abee6 branch Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants