Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 44bb4d7abee6 from angle #25235

Merged
merged 1 commit into from Sep 1, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Aug 31, 2020

D3D11: Fix bug with static vertex attributes.

In some specific cases after binding a zero size buffer we could end
up trying to use a buffer storage that was no longer valid. Fix this
by ensuring we don't flush dirty bits when we have an early exit due
to a zero size buffer.

Also adds a regression test.

Bug: chromium:1107433
Change-Id: I9db560e8dd3699abed2bb7fe6d91060148ba1817
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314216
Commit-Queue: Jamie Madill jmadill@chromium.org
Reviewed-by: Geoff Lang geofflang@chromium.org

Notes: Security: backported fix for 1107433.

@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Aug 31, 2020
@nornagon
Copy link
Member Author

@nornagon nornagon commented Sep 1, 2020

CI failures are unrelated.

@nornagon nornagon merged commit 41b7ab3 into 8-x-y Sep 1, 2020
14 of 16 checks passed
14 of 16 checks passed
@azure-pipelines
electron-arm-testing Build #20200831.35 had test failures
Details
@azure-pipelines
electron-woa-testing Build #20200831.28 had test failures
Details
@trop
Valid Backport Backport Check Skipped
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm64-testing Build #20200831.36 had test failures
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 1, 2020

Release Notes Persisted

Security: backported fix for 1107433.

@nornagon nornagon deleted the cherry-pick/8-x-y/angle/44bb4d7abee6 branch Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants