Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick af5b008a9546 from angle #25262

Merged
merged 2 commits into from Sep 2, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Sep 1, 2020

Fix stale validation cache on buffer deletion.

When we would delete the currently bound element array buffer we
would neglect to invalidate a specific validation cache variable.
This incorrectly would let us skip buffer size validation and lead
to internal invalid memory accesses.

Bug: chromium:1105202
Change-Id: I23ab28ccd3ac6b5d461cb8745b930f4d42d53b35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2323644
Reviewed-by: Jamie Madill jmadill@chromium.org

Notes: Security: backported fix for 1105202.

@nornagon nornagon requested a review from a team as a code owner Sep 1, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2020
@nornagon nornagon added 8-x-y backport-check-skip Skip trop's backport validity checking labels Sep 1, 2020
@nornagon nornagon merged commit ceb2915 into 8-x-y Sep 2, 2020
14 of 15 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 2, 2020

Release Notes Persisted

Security: backported fix for 1105202.

@nornagon nornagon deleted the cherry-pick/8-x-y/angle/af5b008a9546 branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport-check-skip Skip trop's backport validity checking new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants