Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick c4f3b713800f from swiftshader #25266

Merged
merged 1 commit into from Sep 2, 2020

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Sep 1, 2020

Fix copying cubemap textures out of bounds

Cubemap textures are created with a border, which means that their
size is larger. Their range is also different. Instead of [0, dim-1],
they have a [-1, dim] range. This means that if we copy them starting
at [0, 0] for their full size, we'll overflow at the end, since the
buffer starts at [-1, -1]. This cl prevents going through the fast
copy path when we have a border.

Bug: chromium:1115345
Change-Id: I333acfd6094645231eb111634359d82ed3d5c787
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/47668
Presubmit-Ready: Alexis Hétu sugoi@google.com
Reviewed-by: Corentin Wallez cwallez@google.com
Reviewed-by: Chris Forbes chrisforbes@google.com
Tested-by: Alexis Hétu sugoi@google.com

Notes: Security: backported fix for 1115345.

@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Sep 1, 2020
@nornagon nornagon added 8-x-y and removed 9-x-y labels Sep 1, 2020
@nornagon nornagon merged commit 2cf35c0 into 8-x-y Sep 2, 2020
15 of 16 checks passed
15 of 16 checks passed
@azure-pipelines
electron-arm-testing Build #20200901.31 had test failures
Details
@trop
Valid Backport Backport Check Skipped
Details
@electron-archaeologist
Artifact Comparison No Changes
Details
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
@wip
WIP Ready for review
Details
@appveyor
appveyor: win-ia32-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
@appveyor
appveyor: win-woa-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing AppVeyor build succeeded
Details
@appveyor
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
@circleci-checks
build-linux Workflow: build-linux
Details
@circleci-checks
build-mac Workflow: build-mac
Details
@azure-pipelines
electron-arm64-testing Build #20200901.31 succeeded
Details
@azure-pipelines
electron-woa-testing Build #20200901.31 succeeded
Details
@circleci-checks
lint Workflow: lint
Details
@release-clerk
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 2, 2020

Release Notes Persisted

Security: backported fix for 1115345.

@nornagon nornagon deleted the cherry-pick/8-x-y/swiftshader/c4f3b713800f branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants