Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid creating client_id file for empty DIR_CRASH_DUMPS #25309

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 3, 2020

Backport of #25296

See that PR for details.

Notes: fix client_id file being generated in the working directory for node child process

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
@trop trop bot requested a review from deepak1556 Sep 3, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 3, 2020
zcbenz
zcbenz approved these changes Sep 8, 2020
@zcbenz zcbenz merged commit 303b420 into 10-x-y Sep 8, 2020
6 of 7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 8, 2020

Release Notes Persisted

fix client_id file being generated in the working directory for node child process

@zcbenz zcbenz deleted the trop/10-x-y-bp-fix-avoid-creating-client_id-file-for-empty-dir_crash_dumps-1599159178765 branch Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants