Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): devtools now open for background pages #25366

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 8, 2020

Backport of #22217

See that PR for details.

Notes: no-notes

refactor(extensions): remove unused InitWithBrowserContext method

fix(extensions): release background page WebContents to avoid crash

The background page WebContents instance is managed by the ExtensionHost.

fix(extensions): open background page devtools detached by default

test(extensions): add background page devtools test

chore: test fix for null web_contents()

fix: close background page devtools in test after opening
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 8, 2020
@trop trop bot added 11-x-y backport This is a backport PR labels Sep 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 8, 2020
zcbenz
zcbenz approved these changes Sep 10, 2020
@zcbenz zcbenz merged commit 1e1d35f into 11-x-y Sep 10, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 10, 2020

No Release Notes

@zcbenz zcbenz deleted the trop/11-x-y-bp-fix-extensions-devtools-now-open-for-background-pages-1599566157870 branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants