Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure electron delay loads the same modules as chromium #25435

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 12, 2020

Backport of #25428

See that PR for details.

notes: Added missing module delay loads on windows to reduce per process reference set impact

chrdavis and others added 3 commits September 12, 2020 06:01
…ndows

This change adds the same module delay load list that chromium uses for electron.  Some modules were already getting delay loaded from other build files in chromium but not the main list via //build/config/win:delayloads.  We do not include the list of delay loads in delayloads_not_for_child_dll as those have issues being loaded in sandboxes processes.  This will reduce the overall reference set impact of the electron processes.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 12, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 12, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 12, 2020
@MarshallOfSound MarshallOfSound merged commit 2ccfb82 into 10-x-y Sep 14, 2020
5 of 7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 14, 2020

Release Notes Persisted

Added missing module delay loads on windows to reduce per process reference set impact

@MarshallOfSound MarshallOfSound deleted the trop/10-x-y-bp-fix-ensure-electron-delay-loads-the-same-modules-as-chromium-1599890516380 branch September 14, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants