Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call node::Stop on exit #25458

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 14, 2020

Backport of #25430

See that PR for details.

Notes: Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 14, 2020
@trop trop bot requested a review from nornagon September 14, 2020 21:09
@trop trop bot mentioned this pull request Sep 14, 2020
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 14, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 14, 2020
@codebytere codebytere merged commit 7fc5c46 into 10-x-y Sep 15, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 15, 2020

Release Notes Persisted

Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

@codebytere codebytere deleted the trop/10-x-y-bp-fix-call-node-stop-on-exit-1600117746550 branch September 15, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants