Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure ready-to-show event is fired #25471

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 15, 2020

Backport of #25448

See that PR for details.

Notes: Fix ready-to-show event not emitted on some machines.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 15, 2020
@trop trop bot requested a review from zcbenz Sep 15, 2020
@trop trop bot mentioned this pull request Sep 15, 2020
6 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Sep 15, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 15, 2020
zcbenz
zcbenz approved these changes Sep 16, 2020
@zcbenz zcbenz merged commit 51a35f8 into 11-x-y Sep 16, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 16, 2020

Release Notes Persisted

Fix ready-to-show event not emitted on some machines.

@zcbenz zcbenz deleted the trop/11-x-y-bp-fix-ensure-ready-to-show-event-is-fired-1600195744439 branch Sep 16, 2020
@killghost
Copy link

This bug is showedThis bug still exists in electron 13, when can it be fixed? grateful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants