Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure ready-to-show event is fired #25476

Merged
merged 1 commit into from Sep 16, 2020
Merged

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Sep 16, 2020

Backport of #25448

See that PR for details.

Notes: Fix ready-to-show event not emitted on some machines.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
@trop trop bot mentioned this pull request Sep 16, 2020
6 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 16, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
@zcbenz zcbenz force-pushed the ready-to-show-ensure-10 branch from 5a8e703 to b29cfa5 Compare Sep 16, 2020
@codebytere codebytere merged commit 80ef3c7 into 10-x-y Sep 16, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 16, 2020

Release Notes Persisted

Fix ready-to-show event not emitted on some machines.

@codebytere codebytere deleted the ready-to-show-ensure-10 branch Sep 16, 2020
@trop
Copy link
Contributor

trop bot commented Sep 16, 2020

I have automatically backported this PR to "9-x-y", please check out #25490

@trop trop bot added the merged/9-x-y PR was merged to the "9-x-y" branch. label Sep 17, 2020
@codebytere codebytere removed the merged/9-x-y PR was merged to the "9-x-y" branch. label Oct 23, 2020
@killghost
Copy link

This bug still exists in electron 13, when can it be fixed? grateful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants