Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call node::Stop on exit #25501

Merged
merged 2 commits into from Sep 17, 2020
Merged

fix: call node::Stop on exit #25501

merged 2 commits into from Sep 17, 2020

Conversation

nornagon
Copy link
Member

Backport of #25430.

Notes: Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

@nornagon nornagon added the 8-x-y label Sep 16, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
@trop trop bot mentioned this pull request Sep 16, 2020
5 tasks
@trop trop bot added the backport This is a backport PR label Sep 16, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
@@ -153,6 +153,7 @@ int NodeMain(int argc, char* argv[]) {

exit_code = node::EmitExit(env);
env->set_can_call_into_js(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line need to be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's redundant, but it doesn't hurt to remove it.

zcbenz
zcbenz approved these changes Sep 17, 2020
@codebytere codebytere merged commit afe59c5 into 8-x-y Sep 17, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 17, 2020

Release Notes Persisted

Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7.

@codebytere codebytere deleted the backport/8-x-y/node-stop branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants