Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable CORS when webSecurity is disabled #25503

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 16, 2020

Backport of #25463

See that PR for details.

Notes: Fix CORS not being disabled by webSecurity: false.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
@trop trop bot requested a review from zcbenz Sep 16, 2020
@trop trop bot added 10-x-y backport This is a backport PR labels Sep 16, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2020
zcbenz
zcbenz approved these changes Sep 17, 2020
@zcbenz zcbenz merged commit fc91575 into 10-x-y Sep 17, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 17, 2020

Release Notes Persisted

Fix CORS not being disabled by webSecurity: false.

@zcbenz zcbenz deleted the trop/10-x-y-bp-fix-disable-cors-when-websecurity-is-disabled-1600293371489 branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant