Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple window.print() crash #25530

Merged
merged 1 commit into from Sep 18, 2020
Merged

Conversation

codebytere
Copy link
Member

Description of Change

Refs #21397 (comment).

Fixes an issue where the notification registrar would try to remove an already-removed listener during print job release. This has already been handled in master and 11-x-y and so can directly target 10-x-y.

cc @MarshallOfSound @zcbenz @deepak1556

Checklist

Release Notes

Notes: Fixed an issue where multiple calls to window.print() could cause a crash.

@codebytere codebytere added the backport-check-skip Skip trop's backport validity checking label Sep 18, 2020
@codebytere codebytere requested a review from a team as a code owner September 18, 2020 16:37
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 18, 2020
@codebytere codebytere removed the new-pr 🌱 PR opened in the last 24 hours label Sep 18, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 18, 2020
@codebytere codebytere added 10-x-y backport This is a backport PR and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 18, 2020
@codebytere
Copy link
Member Author

Failure is:

BrowserWindow module document.visibilityState/hidden visibilityState is initially visible despite window being hidden - visibilityState is initially visible despite window being hidden

and is unrelated.

@codebytere codebytere merged commit a3ac806 into 10-x-y Sep 18, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 18, 2020

Release Notes Persisted

Fixed an issue where multiple calls to window.print() could cause a crash.

@codebytere codebytere deleted the fix-print-registrar-10 branch September 18, 2020 18:43
@BryanYin
Copy link

Hi @codebytere, does this fix released in any 10-x-y? I'm using 10.1.2 Electron still crashes when print 2nd time...

@codebytere
Copy link
Member Author

@BryanYin nope! not yet

@alex-drocks
Copy link

Thanks for the fix!
It works on Windows 10 now. This is great.

@BryanYin
Copy link

BryanYin commented Oct 6, 2020

@codebytere tried with new 10.1.3, the issue is gone! Thanks for your efforts!

@ibalaji777
Copy link

ibalaji777 commented Jul 29, 2021

Windows 7 missing some content while print ,I am using electron 8.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport This is a backport PR backport-check-skip Skip trop's backport validity checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants