Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check printer list when no default printers #25562

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 21, 2020

Backport of #25515

See that PR for details.

Notes: Fixed an issue where an error would be displayed when using webContents.print() if no default was set and no device name provided.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 21, 2020
@trop trop bot requested a review from codebytere Sep 21, 2020
@trop trop bot added 11-x-y backport This is a backport PR labels Sep 21, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 21, 2020
@codebytere codebytere merged commit a8dc3ae into 11-x-y Sep 22, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 22, 2020

Release Notes Persisted

Fixed an issue where an error would be displayed when using webContents.print() if no default was set and no device name provided.

@codebytere codebytere deleted the trop/11-x-y-bp-fix-check-printer-list-when-no-default-printers-1600720999189 branch Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant