Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): devtools now open for background pages (#22217) #25567

Merged

Conversation

samuelmaddock
Copy link
Member

Backport of #22217

Notes: Fixed extension background page devtools not being openable.

refactor(extensions): remove unused InitWithBrowserContext method

fix(extensions): release background page WebContents to avoid crash

The background page WebContents instance is managed by the ExtensionHost.

fix(extensions): open background page devtools detached by default

test(extensions): add background page devtools test

chore: test fix for null web_contents()

fix: close background page devtools in test after opening
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 22, 2020
@trop trop bot added 9-x-y backport This is a backport PR labels Sep 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 22, 2020
@codebytere codebytere merged commit a43d4ca into electron:9-x-y Sep 22, 2020
4 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 22, 2020

Release Notes Persisted

Fixed extension background page devtools not being openable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants