From 412784300a3a03c61ca64962d3705d0f1246f12e Mon Sep 17 00:00:00 2001 From: samuelmaddock Date: Sun, 27 Sep 2020 17:32:27 -0400 Subject: [PATCH 1/2] chore(extensions): remove unused features json A few of the features we include were copied from Chrome's feature json files. As such, they included a support for contexts unsupported by Electron such as platform apps, hosted apps, and login screens (ChromeOS). Simply put, this will generate extra code not relevant to Electron. --- .../extensions/api/_permission_features.json | 54 +------------------ 1 file changed, 1 insertion(+), 53 deletions(-) diff --git a/shell/common/extensions/api/_permission_features.json b/shell/common/extensions/api/_permission_features.json index 44d71cc852ef8..3f3a3197d1af7 100644 --- a/shell/common/extensions/api/_permission_features.json +++ b/shell/common/extensions/api/_permission_features.json @@ -10,59 +10,7 @@ { "channel": "stable", "extension_types": [ - "extension", - "legacy_packaged_app" - ] - }, - { - "channel": "stable", - "extension_types": [ - "platform_app" - ], - "whitelist": [ - "AE27D69DBE571F4B1694F05C89B710C646792231", // Published ADT - // TODO(grv): clean up once Apps developer tool is published. - "5107DE9024C329EEA9C9A72D94C16723790C6422", // Apps Developer Tool. - "8C0B1873FFFB65E4D0F4D772879F7304CEF125C2", // Apps Editor old. - "FA0501B579070BB9CBD4FCAEC8CB0EDF22BA2F04", // Apps Editor published. - "EE17C698905F7F2E6DDC87C9C30F11E164C829F4", // Watchdog (Activity Log) - "90113DA9516526D24DAF156C629CC41C049E8882", // Watchdog Test Version - "4A4EA121622FCA3D78ED2AB534197F43D7189EE0", // Spark nightly build. - "9FDE6E7F06FCFA11D9A05041C7FF6D8AE662F5D1", // Spark release. - "50B4A905D522C06E27CA6D099E3E54BDA1F152C5", // Spark Beta channel. - "BA0C8BB92084C9741312D90D3EA882526853455F", // Spark dev channel. - "5F57A9AE8DFF5D6BB09DF8606270402612E871E5", // http://crbug.com/422624 - "46578A13607D38F1DC8E280C4F499FB0A2F9565C", // http://crbug.com/819404 - "898FB5A39687D210766B8998BA4530B99C9E6586", // http://crbug.com/819404 - "82F30B65397BC3E4ADE627BBD857AB8A58210648", // http://crbug.com/819404 - "C74B2AF138F9EDECD04D0965AB36CA66C8290466" // http://crbug.com/957772 - ] - }, - { - "channel": "stable", - "extension_types": [ - "hosted_app" - ], - "whitelist": [ - "B44D08FD98F1523ED5837D78D0A606EA9D6206E5" // Web Store - ] - }, - { - "channel": "stable", - "extension_types": [ - "platform_app" - ], - "session_types": [ - "kiosk" - ] - }, - { - "channel": "stable", - "dependencies": [ - "behavior:imprivata_login_screen_extension" - ], - "extension_types": [ - "login_screen_extension" + "extension" ] } ] From 5d030ad2c68fde1b825092d301dead948f387751 Mon Sep 17 00:00:00 2001 From: samuelmaddock Date: Tue, 29 Sep 2020 19:58:26 -0400 Subject: [PATCH 2/2] fix: permission feature array of size 1 needs to be an object --- .../extensions/api/_permission_features.json | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/shell/common/extensions/api/_permission_features.json b/shell/common/extensions/api/_permission_features.json index 3f3a3197d1af7..ecd8f074f6e40 100644 --- a/shell/common/extensions/api/_permission_features.json +++ b/shell/common/extensions/api/_permission_features.json @@ -6,12 +6,10 @@ ], "location": "component" }, - "management": [ - { - "channel": "stable", - "extension_types": [ - "extension" - ] - } - ] + "management": { + "channel": "stable", + "extension_types": [ + "extension" + ] + } } \ No newline at end of file