Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add a wrapper for wrangling uv handles. #25663

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Sep 28, 2020

Backport of #25332

See that PR for details.

Notes: Fixed resource leak in worker threads.

ckerr added 4 commits Sep 28, 2020
Part 1 of a fix for #25248, #22069.

Place the uv_asyncs owned by NodeBindings, ElectronBindings inside a new
UvHandle wrapper class which manages uv_handles' need for their closed()
callback to be invoked before the handles' memory can be freed.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2020
@trop trop bot requested a review from ckerr Sep 28, 2020
@trop trop bot added 9-x-y backport This is a backport PR labels Sep 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 28, 2020
@codebytere codebytere merged commit 220b356 into 9-x-y Sep 28, 2020
7 checks passed
@release-clerk
Copy link

release-clerk bot commented Sep 28, 2020

Release Notes Persisted

Fixed resource leak in worker threads.

@codebytere codebytere deleted the trop/9-x-y-bp-refactor-add-a-wrapper-for-wrangling-uv-handles--1601253240360 branch Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants