Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gdi printing in silent printing mode #25740

Merged
merged 1 commit into from Oct 2, 2020
Merged

fix: gdi printing in silent printing mode #25740

merged 1 commit into from Oct 2, 2020

Conversation

RobertBorg
Copy link
Contributor

backport of #25679

Release Notes

Notes: fix: gdi printing in silent printing mode

@RobertBorg
fix: gdi printing in silent printing mode
2737f3f 
for windows print_text_with_gdi is set to the value of is_modifiable
but this code path is not taken for silent printing
@RobertBorg RobertBorg requested a review from a team as a code owner October 2, 2020 04:25
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 2, 2020
@trop trop bot mentioned this pull request Oct 2, 2020
Merged
4 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 2, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 2, 2020
@codebytere codebytere merged commit 9367708 into electron:10-x-y Oct 2, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 2, 2020

Release Notes Persisted

fix: gdi printing in silent printing mode

@RobertBorg RobertBorg deleted the 10-x-y_fix_silent_gdi_printing branch October 5, 2020 07:16
ghost
ghost reviewed Oct 31, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobertBorg @codebytere