Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Initialize logging for crashpad #26266

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Oct 29, 2020

Backport of #26250

See that PR for details.

Notes: fix debug.log files being created under working directory on windows

@trop trop bot requested a review from as a code owner Oct 29, 2020
@trop trop bot requested a review from deepak1556 Oct 29, 2020
@trop trop bot mentioned this pull request Oct 29, 2020
5 tasks
patches/chromium/.patches Outdated Show resolved Hide resolved
Loading
@codebytere codebytere requested a review from zcbenz Nov 2, 2020
@codebytere codebytere force-pushed the trop/10-x-y-bp-fix-initialize-logging-for-crashpad-1604013848799 branch from 2d57e06 to 4f57b97 Nov 2, 2020
@zcbenz
Copy link
Member

@zcbenz zcbenz commented Nov 3, 2020

The patch fails to apply.

Loading

@deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Nov 3, 2020

Missed this, will look into it. Thanks!

Loading

zcbenz
zcbenz approved these changes Nov 10, 2020
@jkleinsc jkleinsc merged commit 0aef4d6 into 10-x-y Nov 10, 2020
16 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 10, 2020

Release Notes Persisted

fix debug.log files being created under working directory on windows

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants