Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make draggable regions work when devtools is opened on macOS #26394

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Nov 9, 2020

Backport of #26361

See that PR for details.

Notes: Fix draggable regions stops working when devtools is opened on macOS

@codebytere codebytere dismissed their stale review Nov 9, 2020

build failure

@codebytere
Copy link
Member

@codebytere codebytere commented Nov 9, 2020

../../electron/shell/browser/api/electron_api_browser_window_mac.mm:39:21: error: out-of-line definition of 'OnDevToolsResized' does not match any declaration in 'electron::api::BrowserWindow'
void BrowserWindow::OnDevToolsResized() {
                    ^~~~~~~~~~~~~~~~~
1 error generated.
[3 processes, 552/623 @ 8.6/s : 64.546s] OBJCXX obj/electron/electron_framework_shared_library/electron_library_main.o
[2 processes, 553/623 @ 8.2/s : 67.295s] CXX obj/electron/electron_lib/electron_api_app.o
[1 processes, 554/623 @ 6.5/s : 85.323s] CXX obj/electron/electron_lib/tabs_api.o
ninja: build stopped: subcommand failed.

Loading

@zcbenz zcbenz force-pushed the trop/10-x-y-bp-fix-make-draggable-regions-work-when-devtools-is-opened-on-macos-1604958862571 branch from 52175a0 to a611574 Nov 16, 2020
zcbenz
zcbenz approved these changes Nov 16, 2020
Copy link
Member

@zcbenz zcbenz left a comment

The build failure has been fixed.

Loading

@zcbenz zcbenz merged commit 7bd2f0d into 10-x-y Nov 16, 2020
16 of 17 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 16, 2020

Release Notes Persisted

Fix draggable regions stops working when devtools is opened on macOS

Loading

@zcbenz zcbenz deleted the trop/10-x-y-bp-fix-make-draggable-regions-work-when-devtools-is-opened-on-macos-1604958862571 branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants