Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick daad98ce from chromium #26430

Merged
merged 1 commit into from Nov 11, 2020
Merged

Conversation

@ckerr
Copy link
Member

@ckerr ckerr commented Nov 10, 2020

Description of Change

Fixes #26419

The "IsOS/IsAtLeastOS/IsAtMostOS" functions are driven from the Darwin
version number, which is always accurate. Adjust the
SysInfo::OperatingSystemVersionNumbers() function to return accurate
version numbers (or the best we can deduce) so that all version
numbers returned by helper functions are accurate and consistent.

Change-Id: I2ca92478d76bf572cc55875cba443f4978482d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315490

Checklist

Release Notes

Notes: Fixed value of getSystemVersion() on Big Sur

Fixes #26419

The "IsOS/IsAtLeastOS/IsAtMostOS" functions are driven from the Darwin
version number, which is always accurate. Adjust the
SysInfo::OperatingSystemVersionNumbers() function to return accurate
version numbers (or the best we can deduce) so that all version
numbers returned by helper functions are accurate and consistent.

Bug: 1101439
Bug: 1108832
Change-Id: I2ca92478d76bf572cc55875cba443f4978482d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315490
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791491}
@ckerr ckerr requested a review from as a code owner Nov 10, 2020
@jkleinsc jkleinsc merged commit 16b8c06 into 9-x-y Nov 11, 2020
15 of 16 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Nov 11, 2020

Release Notes Persisted

Fixed value of getSystemVersion() on Big Sur

Loading

@jkleinsc jkleinsc deleted the big-sur-version-number/9-x-y branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants