diff --git a/lib/renderer/api/remote.ts b/lib/renderer/api/remote.ts index b30fe3202b02f..1b8419c955d3e 100644 --- a/lib/renderer/api/remote.ts +++ b/lib/renderer/api/remote.ts @@ -298,7 +298,7 @@ function metaToError (meta: { type: 'error', value: any, members: ObjectMember[] } function handleMessage (channel: string, handler: Function) { - ipcRendererInternal.on(channel, (event, passedContextId, id, ...args) => { + ipcRendererInternal.onMessageFromMain(channel, (event, passedContextId, id, ...args) => { if (passedContextId === contextId) { handler(id, ...args); } else { diff --git a/lib/renderer/ipc-renderer-internal-utils.ts b/lib/renderer/ipc-renderer-internal-utils.ts index 709880ffe5cb1..62d12da389af9 100644 --- a/lib/renderer/ipc-renderer-internal-utils.ts +++ b/lib/renderer/ipc-renderer-internal-utils.ts @@ -3,7 +3,7 @@ import { ipcRendererInternal } from '@electron/internal/renderer/ipc-renderer-in type IPCHandler = (event: Electron.IpcRendererEvent, ...args: any[]) => any export const handle = function (channel: string, handler: T) { - ipcRendererInternal.on(channel, async (event, requestId, ...args) => { + ipcRendererInternal.onMessageFromMain(channel, async (event, requestId, ...args) => { const replyChannel = `${channel}_RESPONSE_${requestId}`; try { event.sender.send(replyChannel, null, await handler(event, ...args)); diff --git a/lib/renderer/ipc-renderer-internal.ts b/lib/renderer/ipc-renderer-internal.ts index f35b92a99c37c..60ad784843725 100644 --- a/lib/renderer/ipc-renderer-internal.ts +++ b/lib/renderer/ipc-renderer-internal.ts @@ -29,4 +29,27 @@ ipcRendererInternal.invoke = async function (channel: string, ...args: any[]) return result; }; +ipcRendererInternal.onMessageFromMain = function (channel: string, listener: (event: Electron.IpcRendererEvent, ...args: any[]) => void) { + return ipcRendererInternal.on(channel, (event, ...args) => { + if (event.senderId !== 0) { + console.error(`Message ${channel} sent by unexpected WebContents (${event.senderId})`); + return; + } + + listener(event, ...args); + }); +}; + +ipcRendererInternal.onceMessageFromMain = function (channel: string, listener: (event: Electron.IpcRendererEvent, ...args: any[]) => void) { + return ipcRendererInternal.on(channel, function wrapper (event, ...args) { + if (event.senderId !== 0) { + console.error(`Message ${channel} sent by unexpected WebContents (${event.senderId})`); + return; + } + + ipcRendererInternal.removeListener(channel, wrapper); + listener(event, ...args); + }); +}; + export { ipcRendererInternal }; diff --git a/lib/renderer/web-view/guest-view-internal.ts b/lib/renderer/web-view/guest-view-internal.ts index 0c0d9804ae7f5..4121bd22bcd73 100644 --- a/lib/renderer/web-view/guest-view-internal.ts +++ b/lib/renderer/web-view/guest-view-internal.ts @@ -66,18 +66,18 @@ const dispatchEvent = function ( }; export function registerEvents (webView: WebViewImpl, viewInstanceId: number) { - ipcRendererInternal.on(`ELECTRON_GUEST_VIEW_INTERNAL_DESTROY_GUEST-${viewInstanceId}`, function () { + ipcRendererInternal.onMessageFromMain(`ELECTRON_GUEST_VIEW_INTERNAL_DESTROY_GUEST-${viewInstanceId}`, function () { webView.guestInstanceId = undefined; webView.reset(); const domEvent = new Event('destroyed'); webView.dispatchEvent(domEvent); }); - ipcRendererInternal.on(`ELECTRON_GUEST_VIEW_INTERNAL_DISPATCH_EVENT-${viewInstanceId}`, function (event, eventName, ...args) { + ipcRendererInternal.onMessageFromMain(`ELECTRON_GUEST_VIEW_INTERNAL_DISPATCH_EVENT-${viewInstanceId}`, function (event, eventName, ...args) { dispatchEvent(webView, eventName, eventName, ...args); }); - ipcRendererInternal.on(`ELECTRON_GUEST_VIEW_INTERNAL_IPC_MESSAGE-${viewInstanceId}`, function (event, channel, ...args) { + ipcRendererInternal.onMessageFromMain(`ELECTRON_GUEST_VIEW_INTERNAL_IPC_MESSAGE-${viewInstanceId}`, function (event, channel, ...args) { const domEvent = new Event('ipc-message') as IpcMessageEvent; domEvent.channel = channel; domEvent.args = args; diff --git a/lib/renderer/window-setup.ts b/lib/renderer/window-setup.ts index 87b58409a2e36..1379324e303b6 100644 --- a/lib/renderer/window-setup.ts +++ b/lib/renderer/window-setup.ts @@ -181,7 +181,7 @@ class BrowserWindowProxy { this.guestId = guestId; this._location = new LocationProxy(guestId); - ipcRendererInternal.once(`ELECTRON_GUEST_WINDOW_MANAGER_WINDOW_CLOSED_${guestId}`, () => { + ipcRendererInternal.onceMessageFromMain(`ELECTRON_GUEST_WINDOW_MANAGER_WINDOW_CLOSED_${guestId}`, () => { removeProxy(guestId); this.closed = true; }); @@ -281,7 +281,7 @@ export const windowSetup = ( if (contextIsolationEnabled) internalContextBridge.overrideGlobalValueFromIsolatedWorld(['prompt'], window.prompt); if (!usesNativeWindowOpen || openerId != null) { - ipcRendererInternal.on('ELECTRON_GUEST_WINDOW_POSTMESSAGE', function ( + ipcRendererInternal.onMessageFromMain('ELECTRON_GUEST_WINDOW_POSTMESSAGE', function ( _event, sourceId: number, message: any, sourceOrigin: string ) { // Manually dispatch event instead of using postMessage because we also need to @@ -336,7 +336,7 @@ export const windowSetup = ( let cachedVisibilityState = isHiddenPage ? 'hidden' : 'visible'; // Subscribe to visibilityState changes. - ipcRendererInternal.on('ELECTRON_GUEST_INSTANCE_VISIBILITY_CHANGE', function (_event, visibilityState: VisibilityState) { + ipcRendererInternal.onMessageFromMain('ELECTRON_GUEST_INSTANCE_VISIBILITY_CHANGE', function (_event, visibilityState: VisibilityState) { if (cachedVisibilityState !== visibilityState) { cachedVisibilityState = visibilityState; document.dispatchEvent(new Event('visibilitychange')); diff --git a/typings/internal-electron.d.ts b/typings/internal-electron.d.ts index 8fab594dc4b2c..b249ec456a593 100644 --- a/typings/internal-electron.d.ts +++ b/typings/internal-electron.d.ts @@ -105,6 +105,8 @@ declare namespace Electron { interface IpcRendererInternal extends Electron.IpcRenderer { invoke(channel: string, ...args: any[]): Promise; sendToAll(webContentsId: number, channel: string, ...args: any[]): void + onMessageFromMain(channel: string, listener: (event: Electron.IpcRendererEvent, ...args: any[]) => void): this; + onceMessageFromMain(channel: string, listener: (event: Electron.IpcRendererEvent, ...args: any[]) => void): this; } interface WebContentsInternal extends Electron.WebContents {