Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick bbc6ab5bb49c from chromium #26861

Merged
merged 2 commits into from Dec 10, 2020

Conversation

@ppontes
Copy link
Member

@ppontes ppontes commented Dec 7, 2020

Add ports 5060 and 5061 to the restricted list

Some NAT devices examine traffic on port 5060 to look for a valid SIP
message. If they find one, they will forward a port back to the origin
host. A carefully crafted HTTP request can trick these NAT devices into
forwarding an arbitrary port. See https://samy.pl/slipstream for more
details on the attack and sample code.

Block port 5060 for HTTP. Out of an abundance of caution, and to match
the Fetch standard (whatwg/fetch#1109), also
block port 5061 (SIP over TLS).

Also reduce the whitespace before protocol description comments. This
was insisted on by clang-format and is not worth fighting.

BUG=1145680

(cherry picked from commit 90d1302aec437166b383eabc08af741bf24f7ea8)

(cherry picked from commit dbb0452e69a49e803e0e4cbb6921d5ccad338716)

Change-Id: I3a556fbbb4dc6099caa4418addaf1e89bf254ae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519174
Reviewed-by: Matt Menke mmenke@chromium.org
Commit-Queue: Adam Rice ricea@chromium.org
Cr-Original-Original-Commit-Position: refs/heads/master@{#824254}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525474
Reviewed-by: Adam Rice ricea@chromium.org
Cr-Original-Commit-Position: refs/branch-heads/4280@{#1247}
Cr-Original-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560585
Reviewed-by: Achuith Bhandarkar achuith@chromium.org
Reviewed-by: Victor-Gabriel Savu vsavu@google.com
Commit-Queue: Artem Sumaneev asumaneev@google.com
Cr-Commit-Position: refs/branch-heads/4240@{#1474}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}

Notes: Security: backported the fix to CVE-2020-16022: Insufficient policy enforcement in networking.

@ppontes ppontes force-pushed the cherry-pick/9-x-y/chromium/bbc6ab5bb49c branch from 59692ff to 1321ab1 Dec 9, 2020
zcbenz
zcbenz approved these changes Dec 10, 2020
@zcbenz zcbenz merged commit 662810f into 9-x-y Dec 10, 2020
17 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Dec 10, 2020

Release Notes Persisted

Security: backported the fix to CVE-2020-16022: Insufficient policy enforcement in networking.

Loading

@zcbenz zcbenz deleted the cherry-pick/9-x-y/chromium/bbc6ab5bb49c branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants