Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 3abc372c9c00 from chromium #26895

merged 3 commits into from Dec 11, 2020


Copy link

@nornagon nornagon commented Dec 8, 2020

Apply markup sanitizer in CompositeEditCommand::MoveParagraphs()

CompositeEditCommand::MoveParagraphs() serailizes part of the DOM and
then re-parse it and insert it at some other place of the document. This
is essentially a copy-and-paste, and can be exploited in the same way
how copy-and-paste is exploited. So we should also sanitize markup in
the function.

(cherry picked from commit c529cbcc1bb0f72af944c30f03c2b3b435317bc7)

Bug: 1141350
Change-Id: I25c1dfc61c20b9134b23e057c5a3a0f56c190b5c
Commit-Queue: Yoshifumi Inoue
Reviewed-by: Yoshifumi Inoue
Cr-Original-Commit-Position: refs/heads/master@{#821098}
Reviewed-by: Xiaocheng Hu
Commit-Queue: Xiaocheng Hu
Cr-Commit-Position: refs/branch-heads/4280@{#1099}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}

Notes: Security: backported fix for 1141350.

@nornagon nornagon requested a review from a team as a code owner December 8, 2020 22:45
@nornagon nornagon added 9-x-y backport-check-skip Skip trop's backport validity checking labels Dec 8, 2020
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 8, 2020
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Dec 9, 2020
@codebytere codebytere merged commit a574285 into 9-x-y Dec 11, 2020
Copy link

release-clerk bot commented Dec 11, 2020

Release Notes Persisted

Security: backported fix for 1141350.

@codebytere codebytere deleted the cherry-pick/9-x-y/chromium/3abc372c9c00 branch December 11, 2020 19:03
belenko pushed a commit that referenced this pull request Dec 14, 2020
* chore: cherry-pick 3abc372c9c00 from chromium

* resolve conflict
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants