Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10 #26950

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Dec 11, 2020

Backport of #26924

See that PR for details.

Notes: Fixed an occasional crash on Windows related to NativeViewHost::SetParentAccessible.

This fixes #26905. The patch was obtained from @deepak1556, who in turn
got it from the Microsoft Teams folks.

I believe the crash started happening due to the changes in
https://chromium.googlesource.com/chromium/src.git/+/5c6c8e994bce2bfb867279ae5068e9f9134e70c3%5E!/#F15

This affects Electron 9 and later.

Notes: Fix occasional crash on Windows
@MarshallOfSound MarshallOfSound merged commit e83bd9b into 9-x-y Dec 11, 2020
17 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Dec 11, 2020

Release Notes Persisted

Fixed an occasional crash on Windows related to NativeViewHost::SetParentAccessible.

Loading

@MarshallOfSound MarshallOfSound deleted the trop/9-x-y-bp-fix-avoid-crashing-in-nativeviewhost-setparentaccessible-on-windows-10-1607708905202 branch Dec 11, 2020
belenko pushed a commit that referenced this issue Dec 14, 2020
… 10 (#26950)

* fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows

This fixes #26905. The patch was obtained from @deepak1556, who in turn
got it from the Microsoft Teams folks.

I believe the crash started happening due to the changes in
https://chromium.googlesource.com/chromium/src.git/+/5c6c8e994bce2bfb867279ae5068e9f9134e70c3%5E!/#F15

This affects Electron 9 and later.

Notes: Fix occasional crash on Windows

* Update .patches

* update patches

Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Electron Bot <electron@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants