Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick 5c7ad5393f74 from chromium #27598

Merged
merged 4 commits into from Feb 24, 2021

Conversation

erickzhao
Copy link
Member

Mac a11y: Use the keyboard focusable element for
NSAccessibilityTextChangeElement

When setting the NSAccessibilityTextChangeElement property for
NSAccessibilitySelectedTextChangedNotifications, use the keyboard
focusable element instead of the element that has the focus side of the
text selection. Using the latter, when the element is an empty group,
VoiceOver will focus the containing Web View (when using the VO
cursor follows keyboard focus setting). This makes it impossible to use
the down keyboard key to move past these empty nodes.

VoiceOver cursor" setting in contenteditable nodes.

AX-Relnotes: Fix a bug with the "Synchronize keyboard focus and
Bug: 952922
Change-Id: I3627936726f89b01132c32bd5d83758fc7c3dac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642686
Auto-Submit: Martin Robinson mrobinson@igalia.com
Commit-Queue: Nektarios Paisios nektar@chromium.org
Reviewed-by: Nektarios Paisios nektar@chromium.org
Cr-Commit-Position: refs/heads/master@{#846707}

Release Notes

Notes: Backported fix for https://crbug.com/952922.

@erickzhao erickzhao requested a review from a team as a code owner February 3, 2021 01:25
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 3, 2021
@erickzhao erickzhao added the backport-check-skip Skip trop's backport validity checking label Feb 3, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 3, 2021
@erickzhao erickzhao added the semver/patch backwards-compatible bug fixes label Feb 3, 2021
@zcbenz
Copy link
Member

zcbenz commented Feb 18, 2021

This PR requires review from @electron/wg-upgrades

@codebytere codebytere merged commit 0ee559c into electron:12-x-y Feb 24, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 24, 2021

Release Notes Persisted

Backported fix for https://crbug.com/952922.

@erickzhao erickzhao deleted the bp12/cherry-pick-5c7ad5393f74 branch February 24, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants