-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable system maximization for frameless windows except if transparent #28207
Conversation
4354914
to
c7a7fba
Compare
8281703
to
e9773f9
Compare
Does this break a valid use case where people might want to be able to allow a user to maximize a transparent window with alt+space / titlebar double-click? |
No, this does not break the use case, but that's because it was not working correctly before either. Unfortunately, both using I agree that those are valid use cases though, so disabling these functionalities is just handling the current issues and a new workaround may be good to explore in the future. |
e9773f9
to
1fcd15c
Compare
Release Notes Persisted
|
I have automatically backported this PR to "13-x-y", please check out #28527 |
…parent (#28207) * fix: move widget maximization check * fix linting error * change workaround to only effect transparent windows * disable menu maximize and restore for transparent windows * disable double clicking title bar max/unmax for transparent windows * add docs change and address review
@mlaurencin has manually backported this PR to "12-x-y", please check out #28622 |
…parent (#28207) (#28622) * fix: move widget maximization check * fix linting error * change workaround to only effect transparent windows * disable menu maximize and restore for transparent windows * disable double clicking title bar max/unmax for transparent windows * add docs change and address review
…parent (#28207) * fix: move widget maximization check * fix linting error * change workaround to only effect transparent windows * disable menu maximize and restore for transparent windows * disable double clicking title bar max/unmax for transparent windows * add docs change and address review
…parent (#28207) (#28635) * fix: move widget maximization check * fix linting error * change workaround to only effect transparent windows * disable menu maximize and restore for transparent windows * disable double clicking title bar max/unmax for transparent windows * add docs change and address review Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
Description of Change
Closes #27838
Closes #27264
Previously windows without a frame (including transparent windows) used a workaround in order to maximize properly (See these two PRs: #6417 & #26586). With the latest change however, windows without frames could no longer be properly maximized using the Windows system menu (accessible through
alt + space
).With this PR, the ability to maximize and unmaximize using the Windows system menu and double clicking the title bar, has been disabled for transparent windows. These windows will only be maximizable through Electron's API. Non-transparent frameless windows no longer use the workaround and can be maximized using Electron's API or the Windows system menu interchangeably.
Fiddle for testing
Checklist
npm test
passesRelease Notes
Notes: Transparent windows cannot be maximized using the Windows system menu or by double clicking the title bar.