Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only set backgroundColor in default-app for default index.html #28841

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 26, 2021

Backport of #28792

See that PR for details.

Notes: No longer set backgroundColor in default-app when opening custom files / URLs.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 26, 2021
@trop trop bot requested a review from miniak April 26, 2021 07:29
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 26, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 26, 2021
@codebytere
Copy link
Member

Test failures irrelevant.

shell module shell.trashItem() works in the renderer process

@codebytere codebytere merged commit 37d42ec into 12-x-y Apr 26, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 26, 2021

Release Notes Persisted

No longer set backgroundColor in default-app when opening custom files / URLs.

@codebytere codebytere deleted the trop/12-x-y-bp-fix-only-set-backgroundcolor-in-default-app-for-default-index-html-1619422180658 branch April 26, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants