Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust initial webContents focus calculation #29234

Conversation

@trop
Copy link
Contributor

@trop trop bot commented May 19, 2021

Backport of #29204, #29857

See that PR for details.

Notes:

  • fix incorrect value of document.focus when opening multiple windows on macOS
  • fix key window status on mac when opening panels or using custom window switchers
@deepak1556 deepak1556 dismissed their stale review May 19, 2021

windows failure seems related

@rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented May 20, 2021

@deepak1556 I checked out this branch, built it, and verified that the Windows failure is unrelated.

I ran npm run test -- -g="<webview> tag", and part of the output is below:

ok 65 <webview> tag sendInputEvent can send mouse event
ok 66 <webview> tag media-started-playing media-paused events emits when audio starts and stops playing
ok 67 <webview> tag found-in-page event emits when a request is made
ok 68 <webview> tag <webview>.getWebContentsId can return the WebContents ID
ok 69 <webview> tag <webview>.capturePage() returns a Promise with a NativeImage # SKIP -

@deepak1556
Copy link
Member

@deepak1556 deepak1556 commented May 20, 2021

Thanks for testing, that helps. Looks like the tests are only broken in ci and also only in 13-x-y branch with this change. Have re-run ci a couple of times to make sure these are not flake.

@sofianguy sofianguy added this to Blocks Stable in 13-x-y May 24, 2021
@sofianguy sofianguy removed this from Blocks Stable in 13-x-y May 24, 2021
@deepak1556 deepak1556 force-pushed the trop/13-x-y-bp-fix-adjust-initial-webcontents-focus-calculation-1621416492669 branch from 2d2f2bb to 0282ca4 Jul 1, 2021
@deepak1556 deepak1556 force-pushed the trop/13-x-y-bp-fix-adjust-initial-webcontents-focus-calculation-1621416492669 branch from b5f8ed1 to 1674a4d Jul 14, 2021
@deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jul 14, 2021

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit 2e096ac into 13-x-y Jul 14, 2021
13 of 15 checks passed
@deepak1556 deepak1556 deleted the trop/13-x-y-bp-fix-adjust-initial-webcontents-focus-calculation-1621416492669 branch Jul 14, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jul 14, 2021

Release Notes Persisted

  • fix incorrect value of document.focus when opening multiple windows on macOS
  • fix key window status on mac when opening panels or using custom window switchers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants