diff --git a/shell/common/gin_helper/error_thrower.cc b/shell/common/gin_helper/error_thrower.cc index 52f5f1a863ff6..d555b69a26c63 100644 --- a/shell/common/gin_helper/error_thrower.cc +++ b/shell/common/gin_helper/error_thrower.cc @@ -15,8 +15,6 @@ ErrorThrower::ErrorThrower(v8::Isolate* isolate) : isolate_(isolate) {} // costly to invoke ErrorThrower::ErrorThrower() : isolate_(v8::Isolate::GetCurrent()) {} -ErrorThrower::~ErrorThrower() = default; - void ErrorThrower::ThrowError(base::StringPiece err_msg) const { Throw(v8::Exception::Error, err_msg); } diff --git a/shell/common/gin_helper/error_thrower.h b/shell/common/gin_helper/error_thrower.h index bebc9b7ae42e0..057874e93cc16 100644 --- a/shell/common/gin_helper/error_thrower.h +++ b/shell/common/gin_helper/error_thrower.h @@ -14,8 +14,7 @@ class ErrorThrower { public: explicit ErrorThrower(v8::Isolate* isolate); ErrorThrower(); - - ~ErrorThrower(); + ~ErrorThrower() = default; void ThrowError(base::StringPiece err_msg) const; void ThrowTypeError(base::StringPiece err_msg) const; diff --git a/shell/common/gin_helper/object_template_builder.cc b/shell/common/gin_helper/object_template_builder.cc index 7f80db038ac9a..832f09057f0ff 100644 --- a/shell/common/gin_helper/object_template_builder.cc +++ b/shell/common/gin_helper/object_template_builder.cc @@ -11,8 +11,6 @@ ObjectTemplateBuilder::ObjectTemplateBuilder( v8::Local templ) : isolate_(isolate), template_(templ) {} -ObjectTemplateBuilder::~ObjectTemplateBuilder() = default; - ObjectTemplateBuilder& ObjectTemplateBuilder::SetImpl( const base::StringPiece& name, v8::Local val) { diff --git a/shell/common/gin_helper/object_template_builder.h b/shell/common/gin_helper/object_template_builder.h index 8c9207dc9c4e2..722d6f78bfa79 100644 --- a/shell/common/gin_helper/object_template_builder.h +++ b/shell/common/gin_helper/object_template_builder.h @@ -21,7 +21,7 @@ class ObjectTemplateBuilder { public: ObjectTemplateBuilder(v8::Isolate* isolate, v8::Local templ); - ~ObjectTemplateBuilder(); + ~ObjectTemplateBuilder() = default; // It's against Google C++ style to return a non-const ref, but we take some // poetic license here in order that all calls to Set() can be via the '.'