Prevent Node from adding paths outside the app to search paths #2976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The module system of Node tends to iterate every parent folder of the
required module and add everyone of them to search paths, it makes sense for Node, but in Electron this mechanism may happen to override app's modules with unrelated ones when user's system has lots of Node modules installed.A classic problem is users have third party
dialogmodule installed somewhere, resulting inrequire('dialog')calls in app not working.This PR solves this problem by limiting the propagated paths to be inside the
process.resourcesPath, so packaged app can avoid accidentally using modules installed in user's machine. And forrequirecalls that explicitly use modules outside the app, there will be no limitation, otherwise unexpected behaviors may happen.Fixes #2626.