Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop window.open from hanging when prevented #29881

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jun 24, 2021

Backport of #29851

See that PR for details.

Notes: Fixed a hang when denying a window.open using setWindowOpenHandler when nativeWindowOpen: false.

zcbenz
zcbenz approved these changes Jun 28, 2021
@zcbenz zcbenz merged commit 5bef67a into 12-x-y Jun 28, 2021
14 of 15 checks passed
@zcbenz zcbenz deleted the trop/12-x-y-bp-fix-stop-window-open-from-hanging-when-prevented-1624549865468 branch Jun 28, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jun 28, 2021

Release Notes Persisted

Fixed a hang when denying a window.open using setWindowOpenHandler when nativeWindowOpen: false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants